Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[E-Document Connector] SignUp E-Document Connector #27261

Closed
wants to merge 82 commits into from
Closed

[E-Document Connector] SignUp E-Document Connector #27261

wants to merge 82 commits into from

Conversation

geschwint
Copy link

@geschwint geschwint commented Sep 16, 2024 •
edited by github-actions bot
Loading

E-Documents connector interface implementation between Business Central and SignUp Web API for electronic invoices

Work Item(s)
Fixes #27054
Fixes AB#541805

@github-actions github-actions bot added the linked Issue is linked to a Azure Boards work item label Sep 16, 2024
@geschwint geschwint mentioned this pull request Sep 16, 2024
Closed
@geschwint
Copy link
Author

@aholstrup1 This pull request has replaced #27084 due to using merge instead of rebase policy locally. Thank you for your patience

@geschwint geschwint marked this pull request as ready for review September 16, 2024 08:16
@JesperSchulz JesperSchulz added the Integration GitHub request for Integration area label Sep 16, 2024
Groenbech96
Groenbech96 requested changes Sep 20, 2024
View reviewed changes
@geschwint
Copy link
Author

geschwint commented Sep 24, 2024 •
edited
Loading

Comment on last commit. Resolving object name conflict in module. Can't have two objects with the same name in the same module even if they are in different namespaces. Ref: https://learn.microsoft.com/en-us/dynamics365/business-central/dev-itpro/developer/devenv-namespaces-overview

Error in build: https://github.com/microsoft/ALAppExtensions/actions/runs/10956384133/job/30482980067?pr=27261

@Groenbech96
Copy link
Contributor

Comment on last commit. Resolving object name conflict in module. Can't have two objects with the same name in the same module even if they are in different namespaces. Ref: https://learn.microsoft.com/en-us/dynamics365/business-central/dev-itpro/developer/devenv-namespaces-overview

Error in build: https://github.com/microsoft/ALAppExtensions/actions/runs/10956384133/job/30482980067?pr=27261

Yep i was looking at this issue as well yesterday. Can you find me and ping me on the E-Doc Open Source teams channel?

@Groenbech96
Copy link
Contributor

Groenbech96 commented Feb 13, 2025 •
edited
Loading

No tests are passing atm.
image

@geschwint
Copy link
Author

No tests are passing atm. image

@Groenbech96 We are working on a fix for Auto Tests for the 30098 build. I will also provide to you updated MockService configuration files

Groenbech96
Groenbech96 requested changes Feb 19, 2025
View reviewed changes
Copy link
Contributor

@Groenbech96 Groenbech96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left comments

@geschwint
Copy link
Author

@Groenbech96 All comments resolved, but not the copyright one as I do not know the resolution/answer to it

@TomasNavarro-SignUp
Copy link

TomasNavarro-SignUp commented Feb 21, 2025 •
edited
Loading

@Groenbech96 All comments resolved, but not the copyright one as I do not know the resolution/answer to it

Copyright one resolved too

@Groenbech96
Copy link
Contributor

Closing as this is internally merged.

@Groenbech96 Groenbech96 closed this Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieljonssonsignup danieljonssonsignup danieljonssonsignup left review comments

@andreas-signup andreas-signup andreas-signup left review comments

@TomasNavarro-SignUp TomasNavarro-SignUp TomasNavarro-SignUp left review comments

@pri-kise pri-kise pri-kise approved these changes

@WaelAbuSeada WaelAbuSeada Awaiting requested review from WaelAbuSeada

@aholstrup1 aholstrup1 Awaiting requested review from aholstrup1

@AndreasMoth AndreasMoth Awaiting requested review from AndreasMoth

@Groenbech96 Groenbech96 Awaiting requested review from Groenbech96

Assignees

@Groenbech96 Groenbech96

Labels
Integration GitHub request for Integration area linked Issue is linked to a Azure Boards work item
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BC Idea]: Enable connector with SignUp for E-Documents
8 participants
@geschwint @Groenbech96 @TomasNavarro-SignUp @AndreasMoth @pri-kise @danieljonssonsignup @andreas-signup @JesperSchulz